DBG - testUsed UDisks2 timeout #19572
Closed
+36
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvollmer
added
the
no-test
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
martinpitt
reviewed
Nov 6, 2023
| def testUsed(self): | ||
| def checkUsed(self): |
Comment on lines
+102
to
+111
| def testUsed1(self): | ||
| self.checkUsed() |
There was a problem hiding this comment.
Just call self.testUsed() in the amplifications.
mvollmer
force-pushed
the
storage-udisks-timeout-debug
branch
from
29178f5
to
62cc665
Compare
|
My hunch right now is that we will have to retry the dialog. But let's first try to collect some data on what is actually going wrong. |
mvollmer
force-pushed
the
storage-udisks-timeout-debug
branch
2 times, most recently
from
17ae6cd
to
12be226
Compare
|
On rhos, testUsed seems reliably green. |
mvollmer
force-pushed
the
storage-udisks-timeout-debug
branch
2 times, most recently
from
c369b66
to
eb51f4f
Compare
|
UDisks2 locks the LUKS device during teardown, waits for the cleartext device to disappear, and immediately wipes the partition table, which succeeds (because nothing has /dev/sda open at the time). Then UDisks2 does a BLKRRPART ioctl which fails with EBUSY: something must still have /dev/sda1 open at that time. Maybe udev? But there is no uevent on /dev/sda1 during all of this. Hmm. |
mvollmer
force-pushed
the
storage-udisks-timeout-debug
branch
from
eb51f4f
to
e752a2a
Compare
mvollmer
force-pushed
the
storage-udisks-timeout-debug
branch
4 times, most recently
from
e356e53
to
692e02a
Compare
mvollmer
force-pushed
the
storage-udisks-timeout-debug
branch
from
692e02a
to
966d41e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.